Add prototype of easier comparison with experimental data#86
Draft
jakubkalinski0 wants to merge 1 commit intomasterfrom
Draft
Add prototype of easier comparison with experimental data#86jakubkalinski0 wants to merge 1 commit intomasterfrom
jakubkalinski0 wants to merge 1 commit intomasterfrom
Conversation
grzanka
reviewed
Dec 23, 2025
|
|
||
| # Check required columns exist | ||
| required = [energy_column, ks_column, dose_rate_column] | ||
| missing = [col for col in required if col not in df.columns] |
Collaborator
There was a problem hiding this comment.
python has useful set datastructure with subtract method
Author
There was a problem hiding this comment.
I will be working a lot on this code this week as there is definitely more code than necessary here. I will also be looking to optimize smaller things like the one you pointed out. For now it's more of a general idea than a finished product
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP - plenty of things require simplification and better documentation