Skip to content

Conversation

@markemer
Copy link
Member

@markemer markemer commented Nov 5, 2025

@vercel
Copy link

vercel bot commented Nov 5, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
capacitor-docs Ready Ready Preview Comment Nov 5, 2025 8:25pm

Copy link
Member

@eric-horodyski eric-horodyski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before the "Then, search for firebase-ios-sdk and select it.", you have to click the + button so the prompt on the screenshot appears.

And you can't just search for firebase-ios-sdk, nothing appears, you have to enter the firebase repository url (https://github.com/firebase/firebase-ios-sdk), not just the name. Once it's cached and appears in the "Recently used" then it will appear just by the name, but most users won't have it cached. The screenshot should also be updated to pick from the url, not from "Recently used".

And this should be done on the versioned v6 and v7 too, but let's wait until everything is correct so you don't have to edit all 3 files if more changes are requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants