Skip to content

chore(ci): download iOS simulators#165

Merged
OS-pedrogustavobilro merged 5 commits intomainfrom
ci/verify-ios
Feb 3, 2026
Merged

chore(ci): download iOS simulators#165
OS-pedrogustavobilro merged 5 commits intomainfrom
ci/verify-ios

Conversation

@OS-pedrogustavobilro
Copy link
Contributor

@OS-pedrogustavobilro OS-pedrogustavobilro commented Feb 3, 2026

@OS-pedrogustavobilro OS-pedrogustavobilro requested a review from a team February 3, 2026 11:16
@OS-pedrogustavobilro OS-pedrogustavobilro marked this pull request as draft February 3, 2026 11:16
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you do it on publish-ios.yml file too?

@OS-pedrogustavobilro
Copy link
Contributor Author

OS-pedrogustavobilro commented Feb 3, 2026

I'd reckon we could remove publish-ios.yml and android (not necessarily in this PR). They're not in .github/workflows, they've never run before (that I know of).

@jcesarmobile
Copy link
Member

jcesarmobile commented Feb 3, 2026

yeah, looks like it was missed when moved out of the mono repo, we should fix that (make them run, not remove them), we just had a ticket for fixing publishing in some plugins, but google maps was part of that, should have been.

and we should also update all actions, most of them are on v3 when there is v6 available and still using node 20 instead of 22. We also had tasks for that while the Capacitor 8 work, but was also missed for this plugin.

@OS-pedrogustavobilro OS-pedrogustavobilro marked this pull request as ready for review February 3, 2026 12:14
@jcesarmobile
Copy link
Member

Sorry if I wasn't clear, but I meant in a separate PR and creating a JIRA task first, this one should only be for downloading the iOS simulators

@OS-pedrogustavobilro
Copy link
Contributor Author

Heh got ahead of myself then, my bad xD

@OS-pedrogustavobilro OS-pedrogustavobilro merged commit 0f193f1 into main Feb 3, 2026
7 checks passed
@OS-pedrogustavobilro OS-pedrogustavobilro deleted the ci/verify-ios branch February 3, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants