feat(google-maps): Refactored options and added feature to update the map options#26
Open
AE1NS wants to merge 1 commit intoionic-team:mainfrom
Open
feat(google-maps): Refactored options and added feature to update the map options#26AE1NS wants to merge 1 commit intoionic-team:mainfrom
AE1NS wants to merge 1 commit intoionic-team:mainfrom
Conversation
|
do we have an update on this? |
Contributor
|
AE1NS
force-pushed
the
options-refactoring
branch
from
9ad3c3e to
a0fd3eb
Compare
AE1NS
force-pushed
the
options-refactoring
branch
from
a0fd3eb to
93659c9
Compare
AE1NS
force-pushed
the
options-refactoring
branch
from
93659c9 to
a824323
Compare
Contributor
Author
|
Rebased on the latest commit |
AE1NS
force-pushed
the
options-refactoring
branch
3 times, most recently
from
1d8a7dc to
f9a1892
Compare
AE1NS
force-pushed
the
options-refactoring
branch
from
f9a1892 to
c1b26c9
Compare
Contributor
|
Rebased to latest and checks passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactorings simplify the map options handling and therefore remove many methods, that can now be set in the instantiation of the map but also be updated with a new method.
I also fixed an issue with the padding values in Android, that were used as DP value. I used the getScaledPixels to convert the DP values to screen PX. Now its working fine.
Closes #25