-
Notifications
You must be signed in to change notification settings - Fork 3.2k
docs(v6): Update v6 StackBlitz set up and examples for JavaScript and Angular #4213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
soundproofboot
wants to merge
36
commits into
ionic-team:main
Choose a base branch
from
soundproofboot:updateV6Stackblitz
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
docs(v6): Update v6 StackBlitz set up and examples for JavaScript and Angular #4213
soundproofboot
wants to merge
36
commits into
ionic-team:main
from
soundproofboot:updateV6Stackblitz
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@soundproofboot is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4199
Changes
static/code/stackblitz/v6/html
to allow JavaScript examples to load correctly in StackBlitz.static/code/stackblitz/v6/angular
to allow Angular examples to load correctly in StackBlitz.IonicModule
andstandalone: true
to all Angular examples that need anexample.component.ts
file.addIcons
method in component constructor, creating the component files if they did not exist.version
to string inglobal/Playground
files to match how version is passed in Playgrounds component. I believe it was incorrectly typed but not used in a way that would throw an error. This was necessary to allow a branch for v6 only inloadSourceFiles
where themode
is inserted inmain.ts
.Additional Information
versions.json
and remove the "v6" entry inversionsArchived.json
. This is not in the PR because v6 should not be in the build but will need to be rebuilt and redeployed to Vercel, and the link to the new build updated inversionsArchived.json
.https://developer.school
has two colons but also seems to no longer exist).