-
Notifications
You must be signed in to change notification settings - Fork 3.2k
docs(quickstart): fix JavaScript initialization and update guides to include full file paths #4322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
thetaPC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ShaneK
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me, I just had a question. Feel free to merge if the question is a non-issue
Relates to #446
What is the current behavior?
A user reported in this comment that the JavaScript Quickstart does not work with
npm run preview. I confirmed that this does not work following the existing guide.Additionally, all of the guides do not list file paths starting from the root, nor do the code blocks have titles, making it somewhat trickier to find which files to update.
What is the new behavior?
npm run dev,npm run build && npm run previewand Capacitortitleto all code blocks with the full file pathPreviews