-
Notifications
You must be signed in to change notification settings - Fork 13.5k
fix(modal): add conditional tabIndex for handle cycling #30510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When testing the dev build on the minimal repro, I noticed that I have to tab twice from the increment button to get to the first interactable element within the modal. Is that expected? I would have thought that I only need one tab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try to add a test to prevent regression.
Issue number: resolves internal
What is the current behavior?
Currently, you cannot tab into a sheet modal from outside of it (the background), even with
handleBehavior
set tocycle
. This destroys the accessibility of moving from the background behind a sheet modal to the contents of a sheet modal/the drag bar to be able to cycle the size.What is the new behavior?
Now you can get into a sheet modal from outside of it and interact with its contents/drag handle when
handleBehavior
is set tocycle
. This opens up the accessibility of the sheet modal and allows for interacting with background elements with sheet modals open using accessibility tools like VoiceOver and TalkBack.Does this introduce a breaking change?
Other information
Relevant test screen
Dev build:
8.6.3-dev.11750971489.140836b0