feat(tokens): add gray colors #30799
Draft
+412
−158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
thetaPC
commented
Nov 26, 2025
| // TODO: ADD TYPE | ||
| export const darkPrimitiveColors = { | ||
| // TODO: Update hex values to use the text color variable and background color variable | ||
| gray: generateColorSteps('#ffffff', '#000', true), |
Contributor
Author
There was a problem hiding this comment.
I decided to use white and black for the base because base should be as simple as possible.
thetaPC
commented
Nov 26, 2025
Contributor
Author
There was a problem hiding this comment.
Created this file so these colors can be exported to iOS since iOS uses the same gray colors. I didn't think we needed duplicate code (one for base and one for iOS) when the colors are the same.
thetaPC
commented
Nov 26, 2025
| font-size: 12px; | ||
| font-weight: normal; | ||
|
|
||
| color: var(--ion-color-step-600); |
Contributor
Author
There was a problem hiding this comment.
This wasn't being used anywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #
What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?
Other information