This repository was archived by the owner on May 4, 2022. It is now read-only.
Fix ion-reorder drag and scroll stuck to top or bottom of screen. #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* New drag events where dragged item no longer cause scrolling stop scrolling * Add a cap on the maximum scroll speed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
When dragging an item on a scroll view it will scroll the view when the top/bottom of the screen is reached. However it keeps scrolling until it reaches the top or bottom of the content even if the dragged item isn't on the edge.
Changes proposed in this pull request:
Ionic Version: 1.3.3
Fixes: #224