Skip to content

Feature/consent banner #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Feature/consent banner #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
af2fd2d
Fix eslint config and errors
JosuaMeier Jul 20, 2022
ac8c2b2
feat: Add consent layer as requirement for pixel tracking
JosuaMeier Jul 20, 2022
437adfc
fix: npm audit findings
JosuaMeier Jul 21, 2022
b1b1cda
fix: build step was executed even if deployment was disabled
JosuaMeier Jul 21, 2022
c94421f
Improve loading script and styles for consent banner by using vue-meta
JosuaMeier Jul 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
module.exports = {
env: {
es2021: true,
node: true
node: true,
},
plugins: ['gridsome'],
extends: [
'eslint:recommended',
'plugin:vue/essential',
'plugin:gridsome/recommended',
],
parserOptions: {
ecmaVersion: 2021,
Expand All @@ -16,5 +14,6 @@ module.exports = {
rules: {
'object-curly-spacing': ['error', 'always'],
'comma-dangle': ['error', 'always-multiline'],
}
'vue/multi-word-component-names': 'off',
},
};
3 changes: 2 additions & 1 deletion .github/workflows/deploy-now.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ jobs:
node-version: v14.x

- name: Build Node assets
if: ${{ steps.project.outputs.deployment-enabled == 'true' }}
env:
CI: true
SHOW_BLOG: true
Expand All @@ -56,4 +57,4 @@ jobs:
service-host: api-eu.ionos.space
api-key: ${{ secrets.IONOS_API_KEY }}
dist-folder: dist
runtime-placeholder-files: ${{ steps.template.outputs.runtime-placeholder-files }}
runtime-placeholder-files: ${{ steps.template.outputs.runtime-placeholder-files }}
3 changes: 3 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ npm ci
cp .env.example .env
```

:warning: If .env is missing errors like `Error: Cannot query field "teaser" on type "MarkdownPage".` appear.


### Develop

Run local server.
Expand Down
Loading