Fix issues reported by SonarCloud

[Danielius1922]

No description provided.

[coderabbitai]

Walkthrough

The changes update code formatting, type casting, and package versions across multiple files. They include correcting indentation in a test setup, refining loop boundary types in a test comparison, updating Docker base images and consolidating RUN commands, removing unnecessary casts in function calls, changing pointer casts to const correctness, restructuring TLS read logic for clarity, adding a helper function for memory block freeing, and adding a clarifying comment for Linux clock initialization.

Changes

File(s)	Change Summary
api/unittest/resourcetest.cpp	Corrected indentation of a device descriptor initialization within a test setup method.
security/unittest/doxmtest.cpp	Updated loop boundary in array comparison to use size_t and std::size instead of int and a macro.
docker/apps/Dockerfile.cloud-server	Updated base image from alpine:3.21 to alpine:3.22; reordered package list without changing installed packages.
docker/apps/Dockerfile.cloud-server-debug	Consolidated and reformatted RUN commands for package installation, git submodule update, build, and copy steps without changing functionality.
docker/apps/Dockerfile.cloud-server-debug-clang	Combined package installations into a single command; merged RUN commands for submodule update, build, and copy with improved formatting; no functional changes.
messaging/coap/engine.c	Removed explicit cast to uint32_t for incoming_block_len argument in block-wise response handling call.
security/oc_certs.c	Removed unnecessary pointer cast when assigning certificate subject pointer in oc_certs_extract_CN_for_UUID.
security/oc_oscore_crypto.c	Removed explicit cast to uint8_t when assigning first byte of AEAD nonce buffer.
api/oc_collection.c	Changed cast from oc_collection_t * to const oc_resource_t * in a resource comparison condition.
port/linux/clock.c	Added a comment stating no initialization is needed on Linux in oc_clock_init.
security/oc_tls.c	Restructured TLS application data reading loop and error handling for clarity; inverted allocation check and simplified control flow without changing logic.
util/oc_memb.c	Introduced memb_free_block helper function to centralize memory block freeing logic; replaced inline code with function call.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between db952b8 and 90eb913.

📒 Files selected for processing (5)

• api/oc_collection.c (1 hunks)
• port/linux/clock.c (1 hunks)
• security/oc_certs.c (1 hunks)
• security/oc_tls.c (2 hunks)
• util/oc_memb.c (2 hunks)

✅ Files skipped from review due to trivial changes (3)

• port/linux/clock.c
• api/oc_collection.c
• util/oc_memb.c

🚧 Files skipped from review as they are similar to previous changes (1)

• security/oc_certs.c

🔇 Additional comments (3)

security/oc_tls.c (3)

862-863: LGTM: Improved code formatting

The function call parameters have been properly formatted across multiple lines for better readability.

---

802-810: LGTM: Improved allocation error handling

The allocation check has been properly restructured to return immediately on failure, which follows good defensive programming practices. The early return prevents attempting to use a NULL pointer and makes the error path explicit.

---

811-870: LGTM: Enhanced control flow clarity

The loop restructuring improves the function's readability and maintainability:

• The while (peer->processed_recv_message != NULL) condition clearly indicates the loop continues only while there's a message to process
• Error handling paths properly clean up resources by setting peer->processed_recv_message = NULL or calling oc_tls_free_peer
• The success path at lines 857-867 correctly processes the complete message and exits the loop by nullifying the pointer
• All exit paths are well-defined and prevent resource leaks

The restructuring maintains the original logic while making the control flow more explicit and easier to follow.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[ocf-conformance-test-tool]

🎉 Thank you for your code contribution! To guarantee the change/addition is conformant to the OCF Specification, we would like to ask you to execute OCF Conformance Testing of your change ☝️ when your work is ready to be reviewed.

---

ℹ️ To verify your latest change (4be090a), label this PR with OCF Conformance Testing.

⚠️ Label is removed with every code change.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.3% Coverage on New Code
1.8% Duplication on New Code

See analysis details on SonarQube Cloud