Add autogen coverage tests #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add unit tests to exercise autogen lib_exec.cc code paths in Admin, Bdev, CTE, and CAE modules. These tests increase code coverage from ~76% to 80% by testing Container virtual API dispatch methods: - Runtime::NewTask for all task methods - Runtime::SaveTask/LoadTask with serialization - Runtime::NewCopyTask for task copying - Runtime::Aggregate for task result aggregation - Runtime::DelTask for task cleanup The tests cover: - Admin module (12 methods): Create, Destroy, Monitor, Flush, etc. - Bdev module (7 methods): Create, Destroy, AllocateBlocks, Write, Read, etc. - CTE module (19 methods): RegisterTarget, PutBlob, GetBlob, DelTag, etc. - CAE module (4 methods): ParseOmni, ProcessHdf5Dataset, etc. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add comprehensive SaveTask SerializeOut coverage tests for Admin container covering CreateTask, DestroyTask, GetOrCreatePoolTask, DestroyPoolTask, StopRuntimeTask, SendTask, RecvTask, and SubmitBatchTask - Add SaveTask SerializeOut tests for CTE container covering GetOrCreateTagTask, PutBlobTask, GetBlobTask, DelBlobTask, DelTagTask, GetTagSizeTask, and ReorganizeBlobTask - Add AllocLoadTask roundtrip tests for Admin container covering all major task types - Replace MOD_NAME container tests with direct task serialization tests (MOD_NAME is a template module without a predefined pool ID) - Fix test_compose.cc to handle multiple pools in compose config (search for specific test pool instead of assuming single pool) - Coverage improved from ~66% baseline to 66.25% All 147 tests pass. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Merge main and improve autogen lib_exec coverage from 83.5% to 95.8% by adding LocalSaveTask/LocalLoadTask tests for all modules (admin, bdev, MOD_NAME, CTE core, CAE core). Fix LD_LIBRARY_PATH in CTest to use build directory libraries instead of stale installed ones. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Fix vector copy/move assignment to recalculate OffsetPtr for new address - Use non-waiting MPSC ring buffer variant in contention test to avoid deadlock - Fix IsRuntime() assertion in IPC allocate buffer test - Increase kShmAllocationMultiplier from 1.2 to 2.5 for per-process SHM - Account for BuddyPage header overhead at each expansion level - Add LD_LIBRARY_PATH to per-process SHM CTest properties Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…tests # Conflicts: # context-runtime/test/unit/CMakeLists.txt # context-runtime/test/unit/test_ipc_allocate_buffer.cc # context-transfer-engine/test/unit/CMakeLists.txt # context-transport-primitives/include/hermes_shm/data_structures/ipc/vector.h
- Fix ring buffer MPSC race condition: check Push() return value - Remove references to non-existent APIs in autogen coverage tests - Add LD_LIBRARY_PATH to all CMakeLists.txt test properties - Fix CAE URL assertion: file:/// starts with file: not file:: - Fix CEE double-free: remove manual DelTask on Future-managed tasks - Fix WorkOrchestrator::Finalize() redundant thread joins causing hangs - Fix runtime_cleanup and ipc_errors tests to use _exit(0) for cleanup Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
My bad, I PR'd Jaime's thing that conflicted with this. When you get a chance fix the conflict |
…ibility CEE tests failed on compute nodes because CHI_SERVER_CONF is not set, leaving the CTE pool with no storage targets and causing PutBlob allocation failures. Add explicit AsyncRegisterTarget call in the test fixture to make tests self-contained. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…tests # Conflicts: # context-exploration-engine/api/src/context_interface.cc
Contributor
Author
|
@lukemartinlogan , I merged Jaime's change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes all 152 tests pass with 89% coverage.