fix: check provide strategy before providing newly added filestore blocks#11243
Open
HarukaMa wants to merge 5 commits intoipfs:masterfrom
Open
fix: check provide strategy before providing newly added filestore blocks#11243HarukaMa wants to merge 5 commits intoipfs:masterfrom
HarukaMa wants to merge 5 commits intoipfs:masterfrom
Conversation
HarukaMa
force-pushed
the
fix/filestore/provide-strategy-gate
branch
from
2571283 to
80ff414
Compare
…ocks currently, all blocks added into filestore is provided regardless of which provide strategy is selected, which makes little sense when the current strategy is not "all" (new files might not be pinned with --pin=false or might not be added to MFS). Added a similar check as the blockstore to make the behavior identical between blockstore and filestore.
HarukaMa
force-pushed
the
fix/filestore/provide-strategy-gate
branch
from
80ff414 to
1d77c6f
Compare
- reword heading and description for clarity - link to filestore and urlstore experiment docs - mention both experiments since both use the same code path
lidel
force-pushed
the
fix/filestore/provide-strategy-gate
branch
from
6da66f0 to
9d95603
Compare
lidel
force-pushed
the
fix/filestore/provide-strategy-gate
branch
3 times, most recently
from
3a4f379 to
1377009
Compare
- add positive/negative test pair for filestore provide gating - positive: filestore + "all" strategy provides root and leaf CIDs - negative: filestore + "roots" strategy with --pin=false does not - increase providerTimeout to 30s for CI reliability - replace fixed 500ms DHT sleep with waitForProviderReady: polls 'ipfs provide stat' for SweepingProvider connectivity, then runs a canary provide+findprovs round-trip - add expectNoneProvided for parallel negative assertions to avoid sequential timeout accumulation
lidel
force-pushed
the
fix/filestore/provide-strategy-gate
branch
from
1377009 to
1b22bf6
Compare
…de-strategy-gate # Conflicts: # docs/changelogs/v0.41.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently, all blocks added into filestore is provided regardless of which provide strategy is selected, which makes little sense when the current strategy is not "all" (new files might not be pinned with --pin=false or might not be added to MFS). Added a similar check as the blockstore to make the behavior identical between blockstore and filestore.
I'm personally using "roots" strategy with a custom script to only keep direct pins to the individual files and directories, so I don't provide every raw file block to the network to save some resources. I discovered that kubo was trying to provide all blocks nonetheless. Tested the new code by adding some new files to the filestore and there are no unwanted provides now.