NOIRLAB: Add SSL support to zfiond#447
Draft
olebole wants to merge 12 commits intoiraf-community:mainfrom
Draft
Conversation
36a6a51 to
ffcec45
Compare
e6b5402 to
085e8b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is adopted from the latest NOIRLAB commits, namely:
This adds a new non-standard dependency (openssl) to the build and to further use for development:
xc.c; at least the link path.The changes are used to update the catalogue retrieval for noao.astcat.
Todo
Make it work
It compiles, but cannot download https URLs ("ERROR: Cannot access template file or cannot make copy file"). This also does not work on NOIRLABs version 2.18.1/mac.
The urlget task uses
fcadd, which however does not support https yet.So we will wait with this PR to be functional before merge.
More code review
How to handle openSSL dependency on supported platforms: