Skip to content

Added Djibouti OND v4 #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaron-kaplan merged 1 commit into from
Jan 21, 2026
Merged

Added Djibouti OND v4 #588

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion fbfmaproom/fbfmaproom-sample.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5007,7 +5007,7 @@ countries:
datasets:
defaults:
predictors:
- pnep-v2
- prcp-v4
- rain
predictand: bad-years-rank-v2
observations:
Expand Down Expand Up @@ -5130,6 +5130,19 @@ countries:
pct: quantile
colormap: pne_25
is_poe: no
Copy link

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version numbering skips from v2 to v4, which may cause confusion. Consider clarifying why v3 was skipped, or if v3 exists elsewhere, ensure consistency in the versioning scheme.

Suggested change
is_poe: no
is_poe: no
# Note: Version 3 was an internal experimental configuration and is not exposed in this file; the next public release is v4.

Copilot uses AI. Check for mistakes.
prcp-v4:
Copy link

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The key naming is inconsistent with existing entries. The previous entries use pnep-2023 and pnep-v2, but the new entry uses prcp-v4. For consistency within the Djibouti OND configuration, consider using pnep-v4 or updating all entries to use the prcp- prefix consistently.

Suggested change
prcp-v4:
pnep-v4:

Copilot uses AI. Check for mistakes.
label: Forecast prob non-exc v4
description: NextGen forecast probability of non-exceedance of selected percentile, version 4 (configuration selected Jan 2026)
path: djibouti/prcp-ond-v4.zarr
var_names:
value: pne
lat: Y
lon: X
issue: S
lead: null # dataset has forecasts for only one season; L is implicit.
pct: quantile
colormap: pne_25
is_poe: no

seasons:
season1:
Expand Down
Loading