Open
Conversation
* include base URL in cypress commands * add project id to cypress.json * Muganwas patch 1 (#179) * Ignore IntelliJ files. * Add linting at pre-commit. * add cypress smoke test * ignore cypress files * git hook for push smoke test * Ignore only cypress results * Updated deps after setting local node version. * Ignore cypress example. * Update README. * Add create round smoke test. * Small README update. * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Create main.yml Co-authored-by: Choshun Snyder <csnyder@pandora.com> Co-authored-by: batchku <batchku@gmail.com> * added eslint check to github flow * make sure node modules are installed * use multiple conditions for different envs * change cmd to run * remove pre push hook Co-authored-by: Choshun Snyder <csnyder@pandora.com> Co-authored-by: batchku <batchku@gmail.com>
* changed from cypress run to node_modules/.bin/cypress run * set appropriate url before cypress run * set appropriate url before cypress run
… the actual point of truth for packages are
This reverts commit 27cc215.
* Update how work is added * Update README.md, Fixed typo. Co-authored-by: Muganwa <stevenmuganwa@live.com>
* removed unused vars * layer offsets in its own lane * removed unused & commented out import * Update how work is added (#193) * Update how work is added * Update README.md, Fixed typo. Co-authored-by: Muganwa <stevenmuganwa@live.com> Co-authored-by: Choshun Snyder <choshun.snyder@gmail.com>
* centred play pause button, implementing new design on patter presets ui * patterns & sequences * basic GUI complete * sequence recording graphics * sequence playback animation * revert sequence render and animation * pattern and sequence render and rerender * functional pattern and sequence recording * fixed layer render issue on tempo change * fixed glitch and removed repeated dblclick event listener * automatically set A preset to current round, clear preset sequencers * removed unused var * proper highlighting for patterns and sequence previews * fixed sequence overwrite bug * Revert "fixed sequence overwrite bug" This reverts commit 7b98d87. * Revert "fixed sequence overwrite bug" This reverts commit 7b98d87. * new layer incompatibility fix * Sound glitch inaudible * removed unnecessary part recalculation * remove pause on switch pattern and allow selection of patterns during sequence playback * reintroduction of recalculation on step click * active pattern distinction clear (#271) * active pattern distinction clear * update patterns after layer change * smooth pattern updates, glitch-0 * outline on selected preset pattern * redraw when layer mute status changes (#269) * select pattern on initial load * No highlights for muted layers (#273) * expected modal, solo and mute behaviour (#280) * refactored constants (#278) * refactored constants * tempo button constants setup * removed comments * set next available slot as current(highlighted) (#281) * stop recording when sequence slots are full (#282) * stop recording when sequence slots are full * sequence playback switch constants * Update PlayUI.js (#284) set activePatternId when click action permitted. Sync state and props, isRecordingSequence on component update * dim layers and sequencer (#283) * dim layers and sequencer In addition, save sequence once recording stops * pattern outline opacity fix * Update PlayUI.js Design specifications with a little variation * Update PlayUI.js micro steps to 60% opacity * Update PlayUI.js Removed c log * Update PlayUI.js Increased transparency for pattern preset label and steps * Update PlayUI.js separate prev props vs props and state vs prop comparisons * removed unnecessary comments * Update PlayUI.js cleared commented out code * Update PlayUI.js removed referencing by id from svg elements
dummy use for unused var
removed redundant withStyles
unused var commented out
Multiple file selection and file name display fix
Display proper duration and only use wav files
switched forEach with map
When a custom sound was uploaded a long list of unrecognisable sounds.
muganwas
force-pushed
the
features/285-upload-sounds-and-create-new-instruments
branch
from
3770134 to
b511676
Compare
remove Tone.PolySynth
removed unused var
muganwas
force-pushed
the
features/285-upload-sounds-and-create-new-instruments
branch
from
8138737 to
1269534
Compare
Not working
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.