Open
Conversation
Contributor
|
It would be good to have test for this, perhaps even an integration test that ensures that the library is built correctly and ends up where it needs to be. There's already na integration test here but it builds one of the example project. Perhaps we could have a directory with test projects for the integration test. |
|
Is the simpler solution to not use a crate name with a dash in it at this time? Or how can I help complete this issue? I'd like to use a library with a dash in it, too :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My crate has a dash in the name. Rust libraries can't have dashes.