Open
Conversation
mosuem
commented
Aug 16, 2024
| /// Name of the crate to be built. | ||
| final String? crateName; | ||
|
|
||
| final CrateType? crateType; |
Author
There was a problem hiding this comment.
These need some docs - just wanted to check if I am on the right path first, if yes I will go through this and clean it up.
Contributor
|
Overall this looks good to me. But with all these options expanded I should probably figure out more robust way to test things on CI. Not a blocker for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in dart-lang/i18n#857. I don't know much about Rust, let me know if this makes sense!