feature: Bump native assets cli and fix bug#26
feature: Bump native assets cli and fix bug#26shigomany wants to merge 7 commits intoirondash:mainfrom
Conversation
|
@knopp Hello, can you look this PR? |
|
Hi, apologize for the delay. Any chance you can upgrade the android project so that we can get the CI to pass? |
|
I will try |
|
The windows/android build fails with I'm guessing it's because the path has 261 characters, which requires windows long path support? But I thought it is enabled in the runner images. |
|
Does visual studio linker still not support long paths? |
| logger: logger, | ||
| ); | ||
| } | ||
| // final effectiveBuildMode = release ? BuildMode.release : BuildMode.debug; |
There was a problem hiding this comment.
If this is not needed it should be removed.
knopp
left a comment
There was a problem hiding this comment.
Couple of nits. Once addressed I think I'll merge this and then figure out how to shorten the build paths so that the build passes on windows.
| /// Build config provided to the build callback from `native_assets_cli`. | ||
| final BuildConfig buildConfig; | ||
|
|
||
| // final BuildOutputBuilder outputBuilder; |
There was a problem hiding this comment.
Same thing. If not needed should be removed.
I found general issue about it in Cargo rust-lang/cargo#9770 I also found interesting topic about it here rust-lang/cargo#7986 (comment) I tried reproduce it in my package with your package, but I got error compilation via rustup. Maybe you can do it. I'll try this later. |
|
You right it's issue related with linker MSVC. I don't know how to resolve it in CI because I didn't work with CI GItlab. I mistakenly thought it was related to |
|
@shigomany any chance you're going to update this to work with Debating whether or not to contribute an overhaul to this repo--it's a bit outdated on many fronts (e.g., not using melos v7 + pub workspaces) |
|
Recently I forgot this PR (there a lot of things). I can adapt to |
|
@knopp are you going to redo/update this package? I had started working on a bit of a redo in a personal fork, but if it’s something you’re planning on, that’d be good to know 😀 |
Hello @knopp!
In this PR I upgraded dependencies for
native_assets_cli: ^0.11.0and fixed breaking changes.Also I fixed build for macos how you did #17