Open
Conversation
This reverts commit 5528cc4.
3 tasks
mosuem
reviewed
May 6, 2024
| @@ -0,0 +1,39 @@ | |||
| <!-- | |||
| } | ||
|
|
||
| if (!buildConfig.dryRun) { | ||
| await toolchain.toolchain.rustup.runCommand( |
There was a problem hiding this comment.
For my use case specifically, I probably want to pass some more arguments to cargo, see https://github.com/dart-lang/i18n/blob/main/.github/workflows/intl4x_artifacts.yml. Maybe adding a field List<String> additionalFlags to the RustBuilder might help? I don't know if the order of args matters - that would make things more complicated.
Contributor
Author
There was a problem hiding this comment.
Extra cargo arguments are missing. This slipped my mind. I couldn't even port super_native_extensions (the primary use-case for us right now) to native assets without this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.