Mark "sealed" and "static" where appropriate#361
Mark "sealed" and "static" where appropriate#361jeremy-visionaid merged 1 commit intoironfede:masterfrom
Conversation
This improves code readability and performance.
|
Thanks for the PR! I'm happy to merge it, but it raises a bigger question about why the analyzers aren't triggering for them currently. I hadn't intentionally disabled them, but they're not showing as suggestions for net10.0 for me even though that's the default. So, thanks for bringing it to my attention - It's on my mind to improve the editorconfig and StyleCop enforcement though to catch these kinds of thing. |
|
Based on https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1852, I changed AnalysisLevel to latest-recommended, and set dotnet_code_quality.CA1852.ignore_internalsvisibleto = true, then the warning was triggered. Not sure if both are necessary. Thanks for quick merge :) |
|
Yeah, I've got a local branch with |
|
Oh yup |
This improves code readability and performance.