Conversation
Contributor
jjustin
commented
Sep 24, 2018
jjustin
commented
- Introduced jaeger tracing
- Tracer has been added, that reports spans to jaeger tracer - If jaeger is not running, no tracer is created and no spans are reported
- Function tracing.NewSpan takes span name and function, that is exectued. It's execution time is reported to opantracing.GloblaTracer
- instead of passign around the http request, trace span is now extracted out of context value, that is added to http request context, when root span is created - implemented InjectTracerInRequest function that injects span from provided context to request, which, if sent, be used to attach to a trace
- s3 calls in storage are traced and reported to agent - Add vendor files
- cloudStatusReporter was not included in make up command
- spans are now only tagged as errored, they no longer contain lgo - moved spans to the base of s3 calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.