Skip to content

Bring coord sig fig feedback in line with numeric questions#761

Open
axlewin wants to merge 8 commits intomainfrom
hotfix/coord-sig-figs
Open

Bring coord sig fig feedback in line with numeric questions#761
axlewin wants to merge 8 commits intomainfrom
hotfix/coord-sig-figs

Conversation

@axlewin
Copy link
Contributor

@axlewin axlewin commented Feb 27, 2026

Brings coordinate questions in line with numeric questions in terms of significant figures feedback.

Coordinate questions already showed sig figs feedback in the "correct but too many sig figs" case. This change adds feedback for the "too few sig figs, irrespective of correctness" case if and only if we have exhausted all other relevant feedback options, as is the case for numeric questions.

Also enables significant figures feedback for both subset cases (submission ⊂ correct choice, subset match choice ⊂ submission).

We use null in this context to mean "ignore significant figures", but this was previously causing the required sig figs to default to NUMERIC_QUESTION_DEFAULT_SIGNIFICANT_FIGURES (2).
@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

❌ Patch coverage is 40.00000% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.94%. Comparing base (5d9c0c5) to head (97ec917).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...am/cl/dtg/isaac/quiz/IsaacCoordinateValidator.java 40.00% 18 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #761      +/-   ##
==========================================
- Coverage   39.95%   39.94%   -0.01%     
==========================================
  Files         546      546              
  Lines       23901    23927      +26     
  Branches     2873     2881       +8     
==========================================
+ Hits         9550     9558       +8     
- Misses      13444    13460      +16     
- Partials      907      909       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Don't break early on finding an incorrect sig figs match, in case another choice is a correct sig figs match.
Don't show sig fig feedback for an incorrect value with the correct number of sig figs that matches a choice value to 2s.f.
Assume there will not be distinct choices that differ only by significant figures.
@axlewin axlewin marked this pull request as ready for review February 27, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant