Skip to content

Conversation

@ishikawa
Copy link
Owner

Updating dependent libraries and fix warnings from dialyzer.

@ishikawa
Copy link
Owner Author

lib/fake_http/server.ex:98:call
The function call will not succeed.

Ace.HTTP.Service.port(
  _http_service_name ::
    {:via, Registry, {_, {FakeHTTP.Server.Agent, _} | {FakeHTTP.Server.HTTPService, _}}}
)

breaks the contract
(service()) :: {:ok, :inet.port_number()}

I guess Ace.HTTP.Service.service() should be typed as GenServer.server().
https://github.com/CrowdHailer/Ace/blob/master/lib/ace/http/service.ex#L54

@@ -0,0 +1,3 @@
[
{"lib/fake_http/server/http_service.ex", :no_return}
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave up fixing dialyer's error 😩

mix.exs Outdated
{:ace, "~> 0.18.1"},
# {:ace, "~> 0.18.1"},
# {:ace, path: "../Ace"},
{:ace, github: "ishikawa/Ace", branch: "work/fix-and-add-function-spec"},
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporally changed the location.

@ishikawa
Copy link
Owner Author

Ref CrowdHailer/Ace#139

@ishikawa ishikawa marked this pull request as ready for review February 11, 2020 02:46
@ishikawa ishikawa merged commit de4ab07 into master Feb 11, 2020
@ishikawa ishikawa deleted the work/update-deps-and-fix-dializer-warnings branch February 11, 2020 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants