Fix 'Edge' object has no attribute 'value'#17
Open
nmorel wants to merge 1 commit intoisi-nlp:masterfrom
Open
Conversation
nmorel
force-pushed
the
edge-has-no-attribute-value
branch
from
86ea230 to
b6d526f
Compare
|
I do confirm that this PR fixes an issue for me with NoneType object has no attribute value. Function best_right_neighbor_edge returns Edge | None and Edge object have no value attribute. |
|
Any chance this PR can be closed? I'm also trying to use uroman on Chinese text and this error kills it. |
You can use this fork as I did |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #16