Skip to content

Lower requirement to Python 3.8#22

Open
haja-fgabriel wants to merge 4 commits intoisi-nlp:masterfrom
haja-fgabriel:master
Open

Lower requirement to Python 3.8#22
haja-fgabriel wants to merge 4 commits intoisi-nlp:masterfrom
haja-fgabriel:master

Conversation

@haja-fgabriel
Copy link
Copy Markdown

@haja-fgabriel haja-fgabriel commented May 5, 2025

In our production environment, we use Python 3.8, and this library would really help us in our work. We can’t easily switch to a newer Python version.

Let me know if you have Python 3.9+ behavior apart from union type notations.

Changes done:

  • removed Python 3.10 style of union types
  • removed parenthesized context managers specific to Python 3.10

@haja-fgabriel haja-fgabriel marked this pull request as ready for review May 7, 2025 08:05
@haja-fgabriel haja-fgabriel changed the title [WIP] Lower requirement to Python 3.8 Lower requirement to Python 3.8 May 7, 2025
@haja-fgabriel
Copy link
Copy Markdown
Author

haja-fgabriel commented May 7, 2025

Tested with the Jupyter notebook on Python 3.8.10 in a Codespace environment; after fixing the path to the test files, works smoothly.
@uhermjakob @berquist @thammegowda @joelthe1 it would be awesome if my modifications would make it into production :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant