Feature responsive #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mMiamBundle into feature-responsive
…mMiamBundle into feature-responsive
ncharlot
reviewed
Jun 15, 2017
| @font-size-medium: ceil(@font-size-base * 1.14); // ~16px | ||
| @font-size-medium: ceil(@font-size-base * 1.14); | ||
| // ~16px | ||
|
|
jpottier
reviewed
Aug 3, 2017
| margin-top: 10px; | ||
| margin-bottom: 10px; | ||
| font-weight: bold; | ||
| font-size: 150em; |
Contributor
There was a problem hiding this comment.
certain de la taille ? ça fait beaucoup
| @@ -0,0 +1,55 @@ | |||
| #slideout { | |||
| .slideout-overlay { | |||
| transition: opacity @transition-time ease, z-index 0s linear @transition-time; | |||
Contributor
There was a problem hiding this comment.
je suis pas sûr que le z-index puisse être animé
|
|
||
| &:before { | ||
| font-size: 30px; | ||
| content: '\00d7'; |
Contributor
There was a problem hiding this comment.
pas de variable pour cet icône ? c'est pas très parlant comme ça...
| @navbar-button-border: 0; | ||
| @navbar-button-border-radius: 4px; | ||
| @navbar-cart-bg-witem: @brand-primary; | ||
| @navbar-cart-inumber-color: @navbar-button-bg; |
Contributor
There was a problem hiding this comment.
inumber ? faute de frappe ?
Contributor
Author
There was a problem hiding this comment.
item-number mais ça commençait à être un peut trop verbeux
| <button type="button" class="navbar-toggle" data-target="#slideout"> | ||
| <span class="icon-bar"></span> | ||
| <span class="icon-bar"></span> | ||
| <span class="icon-bar"></span> |
Contributor
There was a problem hiding this comment.
pourquoi ces 3 span strictement identiques ?
Contributor
Author
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Responsive update for branches pages