Ensure that timelimits for joined jobs takes priority over defaults #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a host-specific set of submit options is given at the top-level, this is effectively "derived" for all tests and steps created including the in situ one created during joining of jobs. This results in a joined job calcuating a new required timelimit of N but at submission time the value being overwritten by the previous host-specific value M. This is especially important for joined jobs where the calcuated timelimit MUST be correct and cannot rely on defaults if provided. The changes place all possible values able to be provided in a host-specific submit option block inside one using the current host, whether manually provided or queried.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a host-specific set of submit options is given at the top-level, this is effectively "derived" for all tests and steps created including the in situ one created during joining of jobs. This results in a joined job calcuating a new required timelimit of N but at submission time the value being overwritten by the previous host-specific value M. This is especially important for joined jobs where the calcuated timelimit MUST be correct and cannot rely on defaults if provided.
The changes place all possible values able to be provided in a host-specific submit option block inside one using the current host, whether manually provided or queried.