Open
Conversation
… into its own file
jonathanarnault
requested changes
Feb 5, 2026
jonathanarnault
approved these changes
Feb 5, 2026
ClementDreptin
requested changes
Feb 9, 2026
Contributor
ClementDreptin
left a comment
ClementDreptin
left a comment
There was a problem hiding this comment.
The rendering of <hi> elements broke if they wrap the term entirely. For example, if I have this:
<p>lorem ipsum <hi rend="bold">Gustave Eiffel</hi></p>And the detected term is "Gustave Eiffel", it is not rendered in a <strong> element.
This is testable with the minimal.tei.xml file accessible via the /#ark route here http://localhost:3000/istex-view/#ark/EB779CE5B06E21F3E50053841BAC136B79C4A30C in the "Rendition complète" section.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #140