feat(LIVE-19159) Ignore parameter named 'upid_id' for dns-friendly-rule#37
Merged
robert-blue merged 2 commits intomasterfrom Oct 20, 2025
Merged
feat(LIVE-19159) Ignore parameter named 'upid_id' for dns-friendly-rule#37robert-blue merged 2 commits intomasterfrom
robert-blue merged 2 commits intomasterfrom
Conversation
amiller-isp
reviewed
Oct 20, 2025
| dns-friendly: | ||
| severity: error | ||
| description: Identifier parameter missing DNS-friendly pattern, e.g. ^[a-z0-9]([-a-z0-9]*[a-z0-9])?$ | ||
| given: $..parameters[?((@.name || '').match(/^id[ -_A-Z]|[ -_]id$|[a-z0-9]Id$/))] |
There was a problem hiding this comment.
So the "fix" here is to add special case code to our generic linter to handle one case where we happen to have some non-DNS compliant ID? At the very least this needs a comment as to why we added this and where's it's used.
amiller-isp
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dns-friendly-rule should not apply since UPID ID's are not internal IDs and are formatted differently.