Refactor: Modernize budget viewer state with Signals#193
Open
Patmut254 wants to merge 9 commits intoitalanta:mainfrom
Open
Refactor: Modernize budget viewer state with Signals#193Patmut254 wants to merge 9 commits intoitalanta:mainfrom
Patmut254 wants to merge 9 commits intoitalanta:mainfrom
Conversation
…er, and getRepository
…nd repository integration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How I Did This
I replaced RxJS observables with Angular signals. Changed constructor injection to inject(), converted observables using toSignal(), and used computed() to combine data. Replaced subscriptions with effect() for side effects. Updated templates to pass signal values directly.
Why Signals Are Better Here
Signals are simpler - just call mySignal() to get values. No subscriptions to manage, no memory leaks. The code is cleaner and faster because signals only update what changed, not everything.
Signals vs Observables
Observables are streams of data over time (like button clicks). Signals hold current state (like current user). Observables need subscribe/unsubscribe. Signals handle cleanup automatically. For UI state like budgets, signals are more natural.
Other Paradigm
I've used React hooks. They're simpler to learn but re-render entire components. Signals are faster - they update only what changed.