Skip to content

Remove redundant existence check before DELETE in sqlite_sequence #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
babakjahan merged 2 commits into from
Nov 5, 2025
Merged

Remove redundant existence check before DELETE in sqlite_sequence #39

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70ecd3e
Initial plan
Copilot Nov 4, 2025
0be0c63
Remove redundant check before DELETE in sqlite_sequence
Copilot Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions tests/e2e/global_setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,17 +46,13 @@ async def clear_database():
)
if sequence_check.fetchone():
logger.info("sqlite_sequence table found, resetting auto-increment counters...")
# Only reset sequences for tables that exist in sqlite_sequence
# Delete sequences for all tables (DELETE succeeds even if row doesn't exist)
for table in tables:
table_name = table[0]
sequence_exists = await session.execute(
text("SELECT name FROM sqlite_sequence WHERE name=:table_name"), {"table_name": table_name}
await session.execute(
text("DELETE FROM sqlite_sequence WHERE name=:table_name"), {"table_name": table_name}
)
if sequence_exists.fetchone():
await session.execute(
text("DELETE FROM sqlite_sequence WHERE name=:table_name"), {"table_name": table_name}
)
logger.info(f"Reset sequence for: {table_name}")
logger.info(f"Reset sequence for: {table_name}")
else:
logger.info("No sqlite_sequence table found, skipping sequence reset")

Expand Down