Skip to content

itdove/devaiflow#344: Analysis session prompt includes command template that bypasses skill file learning #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
itdove merged 1 commit into from
Mar 31, 2026
Merged

itdove/devaiflow#344: Analysis session prompt includes command template that bypasses skill file learning #345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions devflow/cli/commands/git_new_command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -882,12 +882,9 @@ def _build_issue_creation_prompt(
])

prompt_parts.extend([
"⚠️ CRITICAL: Use EXACTLY this command format (do not modify syntax):",
"⚠️ CRITICAL: Read the daf-git skill to understand the correct command syntax for creating GitHub/GitLab issues.",
"",
example_command,
"",
"⚠️ The command above is the EXACT format you MUST use. Do not attempt alternative formats.",
" Use this template precisely, filling in your analysis and findings.",
"Use the `daf git create` command to create your issue based on your analysis.",
"",
"After you create the issue, the session will be automatically renamed to 'creation-<issue_number>'",
"for easy identification. Users can reopen with: daf open creation-<issue_number>",
Expand Down Expand Up @@ -1010,12 +1007,9 @@ def _build_multiproject_issue_creation_prompt(
"3. Determine clear, testable acceptance criteria considering all projects",
f"4. Create the GitHub/GitLab issue in {target_repo_name} with your cross-project analysis",
"",
"⚠️ CRITICAL: Use EXACTLY this command format (do not modify syntax):",
"",
example_command,
"⚠️ CRITICAL: Read the daf-git skill to understand the correct command syntax for creating GitHub/GitLab issues.",
"",
"⚠️ The command above is the EXACT format you MUST use. Do not attempt alternative formats.",
" Use this template precisely, filling in your cross-project analysis and findings.",
"Use the `daf git create` command to create your issue based on your cross-project analysis.",
"",
"After you create the issue, the session will be automatically renamed to 'creation-<issue_number>'",
"for easy identification. Users can reopen with: daf open creation-<issue_number>",
Expand Down
14 changes: 4 additions & 10 deletions devflow/cli/commands/jira_new_command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -883,12 +883,9 @@ def _build_ticket_creation_prompt(
])

prompt_parts.extend([
"⚠️ CRITICAL: Use EXACTLY this command format (do not modify syntax):",
"⚠️ CRITICAL: Read the daf-jira skill to understand the correct command syntax for creating JIRA issues.",
"",
example_command,
"",
"⚠️ The command above is the EXACT format you MUST use. Do not attempt alternative formats.",
" Use this template precisely, filling in your analysis and findings.",
"Use the `daf jira create` command to create your ticket based on your analysis.",
"",
parent_note,
])
Expand Down Expand Up @@ -987,12 +984,9 @@ def _build_multiproject_ticket_creation_prompt(
f"5. Use project: {project}; configured defaults: {defaults_str}",
"6. Include detailed description and acceptance criteria based on cross-project analysis",
"",
"⚠️ CRITICAL: Use EXACTLY this command format (do not modify syntax):",
"",
example_command,
"⚠️ CRITICAL: Read the daf-jira skill to understand the correct command syntax for creating JIRA issues.",
"",
"⚠️ The command above is the EXACT format you MUST use. Do not attempt alternative formats.",
" Use this template precisely, filling in your cross-project analysis and findings.",
"Use the `daf jira create` command to create your ticket based on your cross-project analysis.",
"",
parent_note,
]
Expand Down
5 changes: 3 additions & 2 deletions tests/test_jira_new_command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -774,8 +774,9 @@ def test_mock_mode_creates_claude_session(self, temp_daf_home):
# Verify initial prompt contains ticket creation instructions
initial_prompt = claude_session["messages"][0]["content"]
assert "ANALYSIS-ONLY" in initial_prompt
# Issue type is now capitalized (Story instead of story)
assert "daf jira create Story" in initial_prompt
# Verify the prompt instructs to read skill files instead of providing template
assert "Read the daf-jira skill" in initial_prompt
assert "`daf jira create`" in initial_prompt

# Verify assistant response mentions ticket creation
assistant_response = claude_session["messages"][1]["content"]
Expand Down
Loading