Skip to content

[SECURITY] Fix Temporary File Information Disclosure Vulnerability #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[SECURITY] Fix Temporary File Information Disclosure Vulnerability #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion itext/src/main/java/com/itextpdf/text/pdf/PdfStamper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@
import java.io.FileOutputStream;
import java.io.IOException;
import java.io.OutputStream;
import java.nio.file.Files;
import java.security.cert.Certificate;
import java.util.HashMap;
import java.util.List;
Expand Down Expand Up @@ -700,7 +701,7 @@ public static PdfStamper createSignature(final PdfReader reader, final OutputStr
}
else {
if (tempFile.isDirectory())
tempFile = File.createTempFile("pdf", ".pdf", tempFile);
tempFile = Files.createTempFile(tempFile.toPath(), "pdf", ".pdf").toFile();
FileOutputStream fout = new FileOutputStream(tempFile);
stp = new PdfStamper(reader, fout, pdfVersion, append);
stp.sigApp = new PdfSignatureAppearance(stp.stamper);
Expand Down
3 changes: 2 additions & 1 deletion itext/src/test/java/com/itextpdf/testutils/TestResourceUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
import java.io.InputStream;
import java.io.OutputStream;
import java.io.PrintStream;
import java.nio.file.Files;

import com.itextpdf.text.pdf.PdfReader;

Expand Down Expand Up @@ -120,7 +121,7 @@ public static File getBytesAsTempFile(byte[] bytes) throws IOException {
private static File writeStreamToTempFile(String id, InputStream is) throws IOException{
if (is == null) throw new NullPointerException("Input stream is null");

File f = File.createTempFile(TESTPREFIX + id + "-", ".pdf");
File f = Files.createTempFile(TESTPREFIX + id + "-", ".pdf").toFile();
f.deleteOnExit();

final OutputStream os = new BufferedOutputStream(new FileOutputStream(f));
Expand Down
3 changes: 2 additions & 1 deletion pdfa/src/main/java/com/itextpdf/text/pdf/PdfAStamper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
import java.io.FileOutputStream;
import java.io.IOException;
import java.io.OutputStream;
import java.nio.file.Files;

/**
* Extension of PdfStamper that will attempt to keep a file
Expand Down Expand Up @@ -146,7 +147,7 @@ public static PdfAStamper createSignature(final PdfReader reader, final OutputSt
}
else {
if (tempFile.isDirectory())
tempFile = File.createTempFile("pdf", null, tempFile);
tempFile = Files.createTempFile(tempFile.toPath(), "pdf", null).toFile();
FileOutputStream fout = new FileOutputStream(tempFile);
stp = new PdfAStamper(reader, fout, pdfVersion, append, conformanceLevel);
stp.sigApp = new PdfSignatureAppearance(stp.stamper);
Expand Down