Skip to content

Conversation

potoo0
Copy link

@potoo0 potoo0 commented Mar 10, 2025

Why are the changes needed?

Close #157.

Brief change log

  • upgrade clickhouse jdbc from 0.6.4 to 0.8.2,
    breaking: username and password must be set(password allow empty)
  • fix the url of Connector Options in README

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no): no
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@itinycheng
Copy link
Owner

Hi @potoo0

Thanks for this PR.
However, it's quite large and includes many changes unrelated to the PR's purpose.
Can you split those changes into multiple PRs with separate goals? Let this PR be more focused.

@potoo0 potoo0 marked this pull request as draft April 17, 2025 15:11
@potoo0 potoo0 force-pushed the upgrade-jdbc branch 2 times, most recently from e4465c5 to 0b5d1db Compare July 19, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve]: upgrade clickhouse java jdbc to 0.7.0
2 participants