Skip to content

Цыганов Павел, М3335#17

Open
Shokk357 wants to merge 3 commits intoitmo2019:masterfrom
Shokk357:master
Open

Цыганов Павел, М3335#17
Shokk357 wants to merge 3 commits intoitmo2019:masterfrom
Shokk357:master

Conversation

@Shokk357
Copy link

No description provided.

@vercel
Copy link

vercel bot commented Jun 15, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://task-5-git-fork-shokk357-master.itmo-yandex.now.sh

@Shokk357
Copy link
Author

Выполнены пункты: 1, 2.1, 3.1
При удалении любого количества отфильтрованных писем input очищается и предлагаются все письма.

{this.props.visibleLetters.map(letter => {
return (
<LetterSmall
isDark={this.props.isDark}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Попробуй React Contexts
https://reactjs.org/docs/context.html

}

createNewLetter() {
console.log(this.state.create);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не оставляй console.log'и в коде


createNewLetter() {
console.log(this.state.create);
this.setState((state: IState) => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Component<IProps, IState> и сможешь писать меньше типов

isSelected: boolean;
changeAnimation: boolean;
id: number;
deleteChosenLetter: (id :number) => void;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Хороший тон – именовать ожидаемые коллбэки с префиксом on*

onDeleteLetter

date: string;
}

export class LetterSmall extends React.Component {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

b_, bem-cn, bem-react/classname

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants