[codex] restore current core deallocation interface#30
Open
krystophny wants to merge 5 commits intomainfrom
Open
[codex] restore current core deallocation interface#30krystophny wants to merge 5 commits intomainfrom
krystophny wants to merge 5 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore the core helper and teardown interfaces that
GORILLA_APPLETSstill expects from the shared core modules.Root Cause
GORILLA_APPLETScurrently builds against helper routines and exported interfaces that are no longer present inGORILLAmain. The missing setters, deallocation routines, and public exports leave the downstream applets build broken even though the underlying core data structures are still present.What Changed
set_n2andset_n3intetra_grid_settings_modImpact
This restores the core side of the current
GORILLA<->GORILLA_APPLETSinterface so the paired applets fix can build cleanly again.Verification
Test fails on main
Test passes after fix