Skip to content

Fix checkout under Windows#117

Merged
marjohma merged 2 commits intomainfrom
fix-checkout-windows
Mar 24, 2026
Merged

Fix checkout under Windows#117
marjohma merged 2 commits intomainfrom
fix-checkout-windows

Conversation

@zandivx
Copy link
Copy Markdown
Contributor

@zandivx zandivx commented Mar 19, 2026

  • forbid names with same letters just different case
  • check for illegal Windows names

@zandivx zandivx requested a review from marjohma March 19, 2026 18:44
@zandivx zandivx self-assigned this Mar 19, 2026
@qodo-code-review
Copy link
Copy Markdown

ⓘ You are approaching your monthly quota for Qodo. Upgrade your plan

Review Summary by Qodo

Add Windows compatibility pre-commit hooks

✨ Enhancement

Grey Divider

Walkthroughs

Description
• Add pre-commit hooks to detect Windows compatibility issues
• Enable case-conflict detection for cross-platform safety
• Enforce illegal Windows filename validation during checkout
Diagram
flowchart LR
  precommit["Pre-commit Configuration"]
  casecheck["check-case-conflict Hook"]
  winnames["check-illegal-windows-names Hook"]
  precommit -- "adds" --> casecheck
  precommit -- "adds" --> winnames
  casecheck -- "prevents" --> caseissues["Case Conflict Issues"]
  winnames -- "prevents" --> winissues["Windows Name Errors"]
Loading

Grey Divider

File Changes

1. .pre-commit-config.yaml ⚙️ Configuration changes +3/-1

Add Windows compatibility validation hooks

• Added check-case-conflict hook to detect files differing only in case
• Added check-illegal-windows-names hook to prevent Windows-reserved filename usage
• Reordered hooks for logical grouping of file validation checks

.pre-commit-config.yaml


2. KiLCA/flre/conductivity/tests/Wmn_NaN_serg.f90 Additional files +0/-0

...

KiLCA/flre/conductivity/tests/Wmn_NaN_serg.f90


Grey Divider

Qodo Logo

@qodo-code-review
Copy link
Copy Markdown

qodo-code-review bot commented Mar 19, 2026

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0) 📐 Spec deviations (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@marjohma marjohma merged commit 6eec321 into main Mar 24, 2026
1 check passed
@marjohma marjohma deleted the fix-checkout-windows branch March 24, 2026 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants