Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR wraps the previously standalone writeData.f90 subroutines into a new writeData_m module to provide explicit interfaces, and updates callers accordingly to use the module procedures (with explicit arguments where needed).
Changes:
- Introduced
module writeData_minwriteData.f90, making the relevant writer routines public. - Updated time-evolution (tokamak + stellarator) code paths to
use writeData_mand to passtime_ind/ previous-coefficient arrays explicitly. - Updated other call sites (
get_dql,ramp_coil) to passtime_indinto the writer routines that previously relied on implicit host/module state.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
QL-Balance/src/stellarator/time_evol_stell.f90 |
Imports writefort9999_stellarator from writeData_m and passes required previous arrays. |
QL-Balance/src/base/writeData.f90 |
Converts file to writeData_m module; updates routine signatures to take explicit inputs (time_ind, dqle11_prev, dqli11_prev). |
QL-Balance/src/base/time_evolution.f90 |
Imports writefort9999/write_fields_currs_transp_coefs_to_h5 from writeData_m; updates calls to pass explicit arguments. |
QL-Balance/src/base/ramp_coil.f90 |
Imports write_fields_currs_transp_coefs_to_h5 from writeData_m and passes time_ind. |
QL-Balance/src/base/get_dql.f90 |
Imports writer routines from writeData_m and passes time_ind explicitly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2ea61aa to
8b4f1dd
Compare
8b4f1dd to
fcf0ef4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This file has no module, which gives all the subroutines in it an implicit interface (which is unexpected and thus not encouraged). Move them into a module to provide an explicit interface automatically.