Skip to content

Introduce a module for writeData.f90#119

Merged
marjohma merged 1 commit intomainfrom
writedata-module
Mar 26, 2026
Merged

Introduce a module for writeData.f90#119
marjohma merged 1 commit intomainfrom
writedata-module

Conversation

@zandivx
Copy link
Copy Markdown
Contributor

@zandivx zandivx commented Mar 25, 2026

This file has no module, which gives all the subroutines in it an implicit interface (which is unexpected and thus not encouraged). Move them into a module to provide an explicit interface automatically.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR wraps the previously standalone writeData.f90 subroutines into a new writeData_m module to provide explicit interfaces, and updates callers accordingly to use the module procedures (with explicit arguments where needed).

Changes:

  • Introduced module writeData_m in writeData.f90, making the relevant writer routines public.
  • Updated time-evolution (tokamak + stellarator) code paths to use writeData_m and to pass time_ind / previous-coefficient arrays explicitly.
  • Updated other call sites (get_dql, ramp_coil) to pass time_ind into the writer routines that previously relied on implicit host/module state.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
QL-Balance/src/stellarator/time_evol_stell.f90 Imports writefort9999_stellarator from writeData_m and passes required previous arrays.
QL-Balance/src/base/writeData.f90 Converts file to writeData_m module; updates routine signatures to take explicit inputs (time_ind, dqle11_prev, dqli11_prev).
QL-Balance/src/base/time_evolution.f90 Imports writefort9999/write_fields_currs_transp_coefs_to_h5 from writeData_m; updates calls to pass explicit arguments.
QL-Balance/src/base/ramp_coil.f90 Imports write_fields_currs_transp_coefs_to_h5 from writeData_m and passes time_ind.
QL-Balance/src/base/get_dql.f90 Imports writer routines from writeData_m and passes time_ind explicitly.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@marjohma marjohma merged commit 428a708 into main Mar 26, 2026
1 check passed
@marjohma marjohma deleted the writedata-module branch March 26, 2026 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants