Skip to content

[codex] Wrap libneo hdf5_tools in KAMEL#124

Draft
krystophny wants to merge 1 commit intomainfrom
dep-audit/wave-02-hdf5tools
Draft

[codex] Wrap libneo hdf5_tools in KAMEL#124
krystophny wants to merge 1 commit intomainfrom
dep-audit/wave-02-hdf5tools

Conversation

@krystophny
Copy link
Copy Markdown
Member

@krystophny krystophny commented Mar 27, 2026

Summary

  • replace the vendored common/hdf5_tools implementation with a thin compatibility layer over canonical LIBNEO::hdf5_tools
  • keep KAMEL_hdf5_tools as the local module surface so KIM and QL-Balance do not need a broad call-site rewrite
  • make every KAMEL subproject share one libneo build tree and module include directory

Why

KAMEL was carrying its own divergent hdf5_tools implementation.

This PR keeps the KAMEL-facing module name stable, but moves the real implementation back to canonical libneo code. The compatibility layer only preserves the legacy specific entry points that QL-Balance still links against directly.

Linked work

Verification

cmake -S . -B build -G Ninja -DCMAKE_BUILD_TYPE=Release -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DINSTALL_KIM_SYMLINK=OFF -DPython_EXECUTABLE=/usr/bin/python3
cmake --build build -j$(nproc)
ctest --test-dir build --output-on-failure

Result: KIM.x, ql-balance.x, and fouriermodes.x build successfully, and ctest passes 18/18 after the full build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant