Merged
Conversation
Member
Author
|
@phizenz verified that results are unchanged by refactoring, and hybrid simulations run noticeably faster now. Stylistic improvements are still possible (in coordination with @marjohma), but modularization is finished. Ready to merge if you agree with the changes, @krystophny. |
Member
|
@pazathoth yes, please go ahead! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The coefficients in the hybrid-kinetic model are constant in every iteration step and can be computed once beforehand. Before implementing these changes, the subroutines are collected in a module so that array size checks are easier. @phizenz is testing whether the output is the same as before refactoring.