Fix GVEC fetch URL and stabilize GVEC tests#325
Closed
krystophny wants to merge 3 commits intomainfrom
Closed
Conversation
Add test_gvec_boozer and test_gvec_boozer_refcoords_magfie for direct Boozer field comparison. Extend gvec_export_data, gvec_reference_coordinates, and field_gvec for Boozer coordinate handling. Update samplers and simple_main for straight-fieldline starting surface support.
Member
Author
|
Closing this PR because it conflicts with the GVEC removal that is now on main. Rebasing it would reintroduce GVEC files and tests that were intentionally deleted in PR #328, so the current branch is no longer the right vehicle for this work. If any part of the fetch/test work is still needed, it should be respun from current main without reviving the removed GVEC path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gvec-group/gvectheta*/covariant component transform used by SIMPLE's direct field comparisongvecexecutable when needed, compare VMEC and GVEC on the same radial convention, and use a non-coarse VMEC spline order for the tight comparisonVerification