feat: use real Cartesian Boozer chartmaps#327
Merged
krystophny merged 5 commits intofeature/boozer-chartmap-gvecfrom Mar 28, 2026
Merged
feat: use real Cartesian Boozer chartmaps#327krystophny merged 5 commits intofeature/boozer-chartmap-gvecfrom
krystophny merged 5 commits intofeature/boozer-chartmap-gvecfrom
Conversation
f56a72f to
d0cf90f
Compare
krystophny
added a commit
that referenced
this pull request
Mar 27, 2026
## Summary Remove all GVEC library dependencies and related code from SIMPLE. The extended Boozer chartmap format (PR #327) replaces the need for GVEC library linking — field data is now exchanged via NetCDF files. ## Removed - 11 files deleted: field_gvec.f90, vmec_field_adapter.f90, 6 GVEC test files, test data, license - 13 files edited: removed all `#ifdef GVEC_AVAILABLE` blocks, ENABLE_GVEC CMake option, FetchContent, map2disc dependency - Zero GVEC references remain in src/, test/, CMake, or config files (only DOC/ mentions preserved) ## Verification - Build: 927/927 targets compile - Tests: 38/38 Fortran tests pass
6fbfa85 to
ffa67d6
Compare
1de68f3 to
38115fc
Compare
69f1239 to
d283f89
Compare
d283f89 to
35fcf84
Compare
38115fc to
da4c2e2
Compare
35fcf84 to
4700801
Compare
da4c2e2 to
8a16303
Compare
b47e7f8 to
f97010a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switch the Boozer chartmap export/import path to the real Cartesian embedding of the Boozer grid and tighten the end-to-end benchmark artifacts on top of the stacked SIMPLE work.
This top layer does two things:
Dependencies
SIMPLE stack
libneo dependency
The required libneo support is already merged on
main.That libneo change accepts
zeta_convention='boozer', keeps the fastcylandvmecpaths unchanged, and routes the generalized Boozer case through the real Cartesian chartmap inversion path.What changed in this top layer
x,y,z1e-4for QA, QH, and NCSXFinal benchmark scope
Shared QA case
Compared across all three paths:
Observed on the current branch:
|B| = 7.20e-5, max|Δs| = 1.67e-9|B| = 1.47e-4, max|Δs| = 5.50e-10VMEC-only coverage
These remain strict direct-vs-file end-to-end checks:
|B| = 9.51e-5, max|Δs| = 6.97e-9|B| = 9.79e-5, max|Δs| = 3.72e-7Figure-8 GVEC golden case
simple.xx-z,y-z, and multiple 3D viewsVerification
ctest --test-dir build --output-on-failure -R '^(test_e2e_boozer_chartmap|test_figure8_boozer_chartmap)$'Result:
100% tests passed, 0 tests failed out of 2Result:
100% tests passed, 0 tests failed out of 38Review
Primary GVEC/QUASR review: @Rykath
SIMPLE-maintainer follow-up: @krystophny