Open
Conversation
This was referenced Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove
MyMPILibfromlibneocompletely solibneono longer owns MPI wrapper code, tests, docs, or top-level MPI build requirements.What Changed
extra/MyMPILibentirelyMyMPILibuser doc fromlibneotest_mympilibcoverage fromlibneoMyMPILibusage fromtest_arnoldiadd_subdirectory(extra/MyMPILib)PYTHONPATHin CTestWhy
MyMPILibis notlibneocore functionality. Keeping it insidelibneoforced MPI into the default build surface and blurred ownership withNEO-2.Impact
libneono longer exports or buildsMyMPILiblibneono longer requires MPI at top level for its normal buildNEO-2now owns the moved code in the companion PRVerification
Result:
Related