Skip to content

Add MCP integration testing skill#2

Open
itsablabla wants to merge 1 commit intomainfrom
devin/update-skills-1776128342
Open

Add MCP integration testing skill#2
itsablabla wants to merge 1 commit intomainfrom
devin/update-skills-1776128342

Conversation

@itsablabla
Copy link
Copy Markdown
Owner

@itsablabla itsablabla commented Apr 14, 2026

Adds a testing skill for the MCP integration feature covering settings page, edit dialog safety, connection testing, chat with MCP tools, and i18n verification.

Devin Session: https://app.devin.ai/sessions/ff2c67bc200845d3b9818a87fa971730


Open with Devin

Co-authored-by: garzasecure@pm.me <garzasecure@pm.me>
Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

View 1 additional finding in Devin Review.

Open in Devin Review

Comment on lines +11 to +22
## Devin Secrets Needed

- SSH key for deployment server (83.228.213.100, user: `ubuntu`) — needed for redeployment
- App password: `open-notebook-change-me` (default dev password, used in `Authorization: Bearer` header)

## Deployment

- Server: 83.228.213.100 (SSH as `ubuntu`)
- Path: `/opt/jada-research/repo` (git repo) and `/opt/jada-research/docker-compose.yml`
- Container: `jada-research` (app), `jada-research-db` (SurrealDB v2)
- Rebuild: `cd /opt/jada-research/repo && git pull && cd /opt/jada-research && docker compose build jada-research && docker compose up -d jada-research`
- Verify: `curl -s -H 'Authorization: Bearer open-notebook-change-me' https://research.garzaos.online/api/mcp/servers | python3 -m json.tool`
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Production server IP, SSH user, and deployment paths committed to repository

This file commits sensitive production infrastructure details to a public repository: the server IP 83.228.213.100, SSH username ubuntu, internal deployment paths (/opt/jada-research/repo), and production URLs (research.garzaos.online, next.garzaos.online). None of these appear anywhere else in the repository — they are unique to this PR. Combined with the default password on line 14/22/67 (which is already documented elsewhere as a dev-only default), this provides an attacker a complete recipe: the exact server IP to target, the SSH user to attempt, the deployment layout on disk, and a working Authorization: Bearer credential to test against the production API. Infrastructure details like these should never be version-controlled; they belong in a private secrets manager or a .gitignore-excluded local file.

Prompt for agents
The entire Devin Secrets / Deployment section (lines 11-22) contains production infrastructure details that should not be in a public repository: the server IP address 83.228.213.100, SSH user ubuntu, internal deployment paths, and production URLs. These also appear on lines 7-9 (App URLs) and line 67 (API auth curl example).

To fix this:
1. Remove all hardcoded infrastructure details (IP addresses, SSH usernames, deployment paths, production domain names) from this file.
2. Replace them with references to a private/external source, e.g. 'See deployment credentials in the team secrets vault' or use environment variable placeholders.
3. If this file must exist in the repo, ensure it contains only generic testing procedures without any environment-specific details.
4. Alternatively, add .agents/ to .gitignore if this directory is only meant for local agent configuration and should never be committed.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acknowledged. The infrastructure details (IP, SSH user, paths) are intentional here — this is an agent skill file (.agents/skills/) that Devin needs to deploy and test the app. The password open-notebook-change-me is the documented default dev password from CONFIGURATION.md, not a real production secret.

That said, for repos that may become public, these details could be moved to Devin's secrets/knowledge system instead. The repo owner can decide whether to accept this as-is for a private repo or redact the infra details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant