mvcdec: Integer overflow in 'ih264d_cavlc_parse_chroma_dc' #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the spec, the values of both the chroma DC transform outputs and the corresponding quantization outputs should be within -(1 << 15) and ((1 << 15) - 1). This check has been now added to the functions, with an early exit when the constraints are not met. Bug = ossfuzz:65055 Test: mvc_dec_fuzzer
harishdm
reviewed
Dec 20, 2023
Member
harishdm
left a comment
harishdm
left a comment
There was a problem hiding this comment.
As this impacts avc path as well, please put this on hold for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the spec, the values of both the chroma DC transform outputs and the corresponding quantization outputs should be within -(1 << 15) and ((1 << 15) - 1). This check has been now added to the functions, with an early exit when the constraints are not met.
Bug = ossfuzz:65055
Test: mvc_dec_fuzzer