Skip to content

fix: allow null issue server ids in websocket broadcasts #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
itz4blitz merged 1 commit into from
Mar 30, 2026
Merged

fix: allow null issue server ids in websocket broadcasts #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions apps/backend/src/modules/issues/issues.gateway.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ interface IssueUpdatePayload {

interface IssueBroadcast {
id: string;
serverId?: string;
serverId?: string | null;
[key: string]: unknown;
}

Expand Down Expand Up @@ -83,6 +83,7 @@ export class IssuesGateway {
* Broadcast a new issue to subscribers
*/
broadcastNewIssue(issue: IssueBroadcast): void {
const serverId = issue.serverId;
const payload: IssueUpdatePayload = {
type: 'new',
issueId: issue.id,
Expand All @@ -91,40 +92,42 @@ export class IssuesGateway {

// Broadcast to both server-specific room and 'all' room
this.server.to('issues:all').emit('issue:new', payload);
if (issue.serverId !== undefined && issue.serverId.length > 0) {
this.server.to(`issues:${issue.serverId}`).emit('issue:new', payload);
if (serverId !== undefined && serverId !== null && serverId.length > 0) {
this.server.to(`issues:${serverId}`).emit('issue:new', payload);
}
}

/**
* Broadcast an issue update to subscribers
*/
broadcastIssueUpdate(issue: IssueBroadcast): void {
const serverId = issue.serverId;
const payload: IssueUpdatePayload = {
type: 'updated',
issueId: issue.id,
data: issue,
};

this.server.to('issues:all').emit('issue:updated', payload);
if (issue.serverId !== undefined && issue.serverId.length > 0) {
this.server.to(`issues:${issue.serverId}`).emit('issue:updated', payload);
if (serverId !== undefined && serverId !== null && serverId.length > 0) {
this.server.to(`issues:${serverId}`).emit('issue:updated', payload);
}
}

/**
* Broadcast when an issue is resolved
*/
broadcastIssueResolved(issue: IssueBroadcast): void {
const serverId = issue.serverId;
const payload: IssueUpdatePayload = {
type: 'resolved',
issueId: issue.id,
data: issue,
};

this.server.to('issues:all').emit('issue:resolved', payload);
if (issue.serverId !== undefined && issue.serverId.length > 0) {
this.server.to(`issues:${issue.serverId}`).emit('issue:resolved', payload);
if (serverId !== undefined && serverId !== null && serverId.length > 0) {
this.server.to(`issues:${serverId}`).emit('issue:resolved', payload);
}
}

Expand Down
Loading