Asynchronous suggestions for field values with a limit#52
Closed
binary-data wants to merge 5 commits intoivelum:masterfrom
binary-data:limit-autocomplete-items
Closed
Asynchronous suggestions for field values with a limit#52binary-data wants to merge 5 commits intoivelum:masterfrom binary-data:limit-autocomplete-items
binary-data wants to merge 5 commits intoivelum:masterfrom
binary-data:limit-autocomplete-items
Conversation
Contributor
|
@stebunovd This PR has been waiting for a while for a review, along with #23 and #35 Do you want some help reviewing the PR's? There are some senior python engineers at 15Five who are interested in open source, I could see if they want to help out. |
Author
|
@caleb15 Last time we reviewed this PR it wasn't ready for merge. I believe it won't get much attention from me, I barely have time for this in the near future, unfortunately. |
Member
|
hey guys, sorry for the long wait, and I appreciate the offer for help. I plan to work on this task soon, please hold on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introducing async loading of field values from backend, as discussed in #36, reducing the initial load and avoid large recordsets.
The tradeoff here is adding multiple requests to the backend.
Users can override the default limit of 50 entries and set their own limits for suggestions.