Improve audio file loading error handling and logging#16
Merged
Conversation
Remove unnecessary `ensureRunning()` call from the file input handler. The `change` event from a file input may not qualify as a user activation in some browsers, causing `AudioContext.resume()` to block or fail silently. Since `decodeAudioData` and node creation work on a suspended context, `ensureRunning()` is not needed here — it is already called when the user clicks Play. Also add `console.error` to the catch block for easier debugging. https://claude.ai/code/session_01W4ZqXjt5v7W8B5hmP22Z1P
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enhanced error handling in the file input handler to provide better debugging information when audio file loading fails.
Key Changes
player.ensureRunning()call that was executed before file loading, allowing the player to initialize naturally during the load processImplementation Details
The
player.ensureRunning()call was moved out of the try block since it was being called before the actual file load operation. This allows the player to be properly initialized as part of theloadFromBlob()operation rather than as a separate preliminary step. The error is now captured and logged to the console, making it easier to diagnose issues during development and troubleshooting.https://claude.ai/code/session_01W4ZqXjt5v7W8B5hmP22Z1P