Skip to content

Conversation

@shapr
Copy link

@shapr shapr commented Mar 6, 2024

this is a quick hack to get orgmode-parse to build with ghc 9.6.3.
If this is something you want to merge, I can improve the PR!

@shapr
Copy link
Author

shapr commented Mar 7, 2024

I suspect the first request would be "turn off the autoformatters and submit again"
which I am happy to do!

@ixmatus
Copy link
Owner

ixmatus commented Mar 11, 2024

Thank you for the contribution @shapr! I'm happy to accept contributions though, I must warn you, I don't actively maintain this project any more myself.

If you are using and you have more contributions coming, I'd be happy to consider giving you the commit bit.

In the meantime, yes, I would change this PR to only include the changes necessary to get building with GHC 9.6.3.

I'm happy to accept a reformatting change request but I'd like for it to be a separate PR so that the changes are logically separated.

@ixmatus
Copy link
Owner

ixmatus commented Mar 11, 2024

(For formatting code, I have a pretty strong preference for fourmolu with the rules file checked-in, that way all developers have the same formatting rules, I don't particularly care what the formatting is, as long as it is easy for all developers to run the formatter.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants